Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incomplete attribution in images/license.json #265

Closed
pixelzoom opened this issue Dec 18, 2018 · 2 comments
Closed

incomplete attribution in images/license.json #265

pixelzoom opened this issue Dec 18, 2018 · 2 comments
Assignees
@pixelzoom
Labels
dev:code-review status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259.

In images/license.json, "Mariah" needs a last name.

  "water_drop.png": {
    "text": [
      "Copyright 2018 University of Colorado Boulder"
    ],
    "projectURL": "http://phet.colorado.edu",
    "license": "contact [email protected]",
    "notes": "Copied and cropped from States of Matter on Aug 3, 2018.  Originally created by Mariah, see water_drop.ai"
  },
@samreid samreid mentioned this issue Dec 18, 2018
Closed
samreid added a commit that referenced this issue Dec 18, 2018
@samreid
Add last name, see #265
68f6805
@samreid
Copy link
Member

samreid commented Dec 18, 2018

Proposed fix pushed, ready for review.

@samreid samreid assigned pixelzoom and unassigned samreid Dec 18, 2018
@pixelzoom
Copy link
Contributor Author

Confirmed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom