-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation-notes.md issues #264
Comments
I fixed quite a bit of formatting in the above commits. Remaining issues for @samreid to address:
|
I'm not seeing the problem. The current value is:
Giving each function call a "nickname", this is equivalent to:
Can you please elaborate? I'm probably missing something. |
You're right, it's wellformed - I got lost in the parens. |
Fixed in aforementioned commit. |
I fixed the type name, thanks!
Good idea! I added numerous links to source files. |
implementation-notes.md says:
I had a difficult time locating the transforms related to these. How about some "see..." pointers for each? |
... for example, I see this in BarriersNode: // @private - Convert from model coordinates to view coordinates
this.modelViewTransform = ModelViewTransform2.createRectangleMapping(
this.scene.getWaveAreaBounds(),
viewBounds
);
var latticeBounds = new Bounds2( 0, 0, 1, 1 );
var modelBounds = scene.modelToLatticeTransform.viewToModelBounds( latticeBounds );
var tempViewBounds = this.modelViewTransform.modelToViewBounds( modelBounds );
//REVIEW missing visibility annotation
this.latticeToViewTransform = ModelViewTransform2.createRectangleMapping( latticeBounds, tempViewBounds ); ... and I suspect that these are what is being referred to in implementation-notes.md. But why are the transforms in BarrierNode, a view component that is specific to the Slits screen? |
|
Adding "see..." pointers should do it. |
On hold until #292 is resolved. |
I updated the docs as part of #292, @pixelzoom can you please review and advise? |
Description of coordinate frames and transforms looks good. I made some minor changes in the above commit. Looks like all other points have been addressed, so feel free to close this if there's nothing else to do. |
Thanks for the link and formatting, closing. |
Related to code review #259, where @samreid said:
There are some formatting problems, and I have a couple of specific questions.
The text was updated successfully, but these errors were encountered: