Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelated wave #256

Closed
KatieWoe opened this issue Dec 14, 2018 · 8 comments
Closed

Pixelated wave #256

KatieWoe opened this issue Dec 14, 2018 · 8 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#238
Under some circumstances the waves can look rather pixelated. This seems to occur more when frequency is high and separation is small, but is noticeable in other circumstances as well.
image

@samreid
Copy link
Member

samreid commented Dec 15, 2018

We use an optimization in LatticeCanvasNode that accelerates performance and makes iPad 2 usage possible (though not great) and gives great performance on iPad 4. The optimization is that the entire lattice is rendered as one cell = one pixel, then that is blown up.

Perhaps changing to a WebGL renderer could offer more resolution without increasing CPU demands. It could take 4-12 hours to get a version ready for testing, but would be quicker to run a feasibility test. Note: we would not change the physics or increase the resolution of the model lattice at all, but we would interpolate cell values in the rendering phase on the GPU. I'm interested to see what this looks like, but will not spend a significant amount of time on it until discussing with @arouinfar @ariel-phet or @kathy-phet.

@ariel-phet
Copy link

ariel-phet commented Dec 17, 2018

@samreid that sounds worthy of investigation for 2.0, not for 1.0. Lets defer for the moment.

@arouinfar
Copy link
Contributor

@samreid @ariel-phet I haven't noticed too many pixelated situations like the one in #256 (comment), so it definitely seems reasonable to defer.

@kathy-phet
Copy link

I've noticed pixelation occuring sometimes too. It seems somewhat unpredictable, and I've seen it create some odd readings on the charting tool too.

I think its worth investigating WebGL as an alternative, but agree it can be deferred to 2.0.

@samreid
Copy link
Member

samreid commented Dec 17, 2018

It seems somewhat unpredictable, and I've seen it create some odd readings on the charting tool too.

The proposed usage of WebGL would only apply in the view layer--would not change the underlying model values or what is shown on the charts. Should we open another issue to investigate odd readings on the charting tool?

@samreid
Copy link
Member

samreid commented Feb 6, 2019

Here's how the same scene looks after we increased the lattice size:

image

@arouinfar does this look OK to you? Can this issue be closed?

@arouinfar
Copy link
Contributor

@samreid I think the increased lattice size adequately addresses the original issue. However, there should probably be a separate issue for WebGL investigation for 2.0, since I know it's come up a few times now.

@samreid
Copy link
Member

samreid commented Feb 6, 2019

I reopened #66 and will close this particular issue.

@samreid samreid closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants