Sometimes the RoundStickyPushButton highlights wrong

[samreid]

Discovered during #227. Sometimes the highlight looks like "pressed" instead of "shiny"

[samreid]

It seems that StickyToggleButtonInteractionStateProperty.buttonModel.looksPressedProperty is somehow true for this case, will require further investigation.

[samreid]

Here's the docs for looksPressedProperty

    // @public - This Property was added for a11y. It tracks whether or not the button should "look" down. This
    // will be true if downProperty is true or if an a11y click is in progress. For an a11y click, the listeners
    // are fired right away but the button will look down for as long as PressListener.a11yLooksPressedInterval.
    // See PressListener.click for more details.
    this.looksPressedProperty = new BooleanProperty( false );

Assigning @jessegreenberg for investigation.

[jessegreenberg]

Oops, sorry for the hassle. This is related to phetsims/ph-scale#71. The button looks pressed because StickyToggleButtonModel.downProperty is still true after the toggle button's valueProperty is set by the sim.

This was fixed in ph-scale by updating the downProperty with the valueProperty in MomentaryButtonModel. We need to do the same in StickyToggleButtonModel as well as any other subtypes of ButtonModel where you can control the button value Property and expect the button view to update accordingly.

Ill create an issue in sun to search for these.

[jessegreenberg]

This should be fixed in master, @samreid can you please confirm?

[samreid]

I can't seem to break it any more, thanks for the fix!