Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure credits are correct before publication #195

Closed
samreid opened this issue Nov 26, 2018 · 7 comments
Closed

Ensure credits are correct before publication #195

samreid opened this issue Nov 26, 2018 · 7 comments

Comments

@samreid
Copy link
Member

samreid commented Nov 26, 2018

From #191

Does a GitHub issue exist for tracking credits, to ensure that they are correct before publication?

@samreid samreid self-assigned this Nov 26, 2018
@samreid
Copy link
Member Author

samreid commented Nov 28, 2018

Credits are currently:

  const simOptions = {
    credits: {
      leadDesign: 'Amy Rouinfar',
      softwareDevelopment: 'Sam Reid',
      team: 'Diana López, Ariel Paul, Kathy Perkins',
      qualityAssurance: 'Katie Woessner, Laura Rea, Steele Dalton, Liam Mulhall',
      graphicArts: 'Cheryl McCutchan, Amy Rouinfar'
    },
    showSmallHomeScreenIconFrame: true
  };

@arouinfar @KatieWoe does this seem correct to you?

@samreid samreid assigned KatieWoe and arouinfar and unassigned samreid Nov 28, 2018
samreid added a commit that referenced this issue Nov 28, 2018
@samreid
Copy link
Member Author

samreid commented Nov 28, 2018

In the preceding commit, I also added @KatieWoe to the "team" part of the credits.

@arouinfar
Copy link
Contributor

@samreid we should also credit the legacy design team. Please add Wendy Adams to the team, and Noah Podolefsky to leadDesign. You can also remove me from graphicArts, since I'm already credited in leadDesign.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Nov 28, 2018
@KatieWoe
Copy link
Contributor

@samreid, so far for qa.

samreid added a commit that referenced this issue Nov 28, 2018
samreid added a commit that referenced this issue Nov 28, 2018
@samreid
Copy link
Member Author

samreid commented Nov 28, 2018

Credits now read:

  const simOptions = {
    credits: {
      leadDesign: 'Amy Rouinfar, Noah Podolefsky',
      softwareDevelopment: 'Sam Reid',
      team: 'Diana López, Ariel Paul, Kathy Perkins, Katie Woessner, Wendy Adams',
      qualityAssurance: 'Katie Woessner, Laura Rea, Steele Dalton, Liam Mulhall',
      graphicArts: 'Cheryl McCutchan'
    },
    showSmallHomeScreenIconFrame: true
  };

Close if all is well.

@samreid samreid assigned arouinfar and unassigned samreid and KatieWoe Nov 28, 2018
@arouinfar
Copy link
Contributor

👍

phet-steele added a commit that referenced this issue Nov 28, 2018
@phet-steele
Copy link
Contributor

I alphabetized SOME credits in the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants