Factor out allRanges, see #293

phetsims · Jan 1, 2019 · 3fd5ade · 3fd5ade
1 parent 36f41ea
commit 3fd5ade
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/js/interference/view/SeparationControl.js b/js/interference/view/SeparationControl.js
@@ -37,6 +37,7 @@ define( require => {
       const waterSceneRange = waterSeparationProperty.range;
       const soundSceneRange = soundSeparationProperty.range;
       const lightSceneRange = lightSeparationProperty.range;
+      const allRanges = [ waterSceneRange, soundSceneRange, lightSceneRange ];
 
       // Switch between controls for each scene.  No advantage in using SceneToggleNode in this case
       // because the control constructor calls are substantially different.
@@ -47,23 +48,23 @@ define( require => {
           valuePattern: cmValueString,
           decimalPlaces: 1,
           constrainValue: value => Util.roundToInterval( value, 0.5 ),
-          majorTicks: createTicks( waterSceneRange, [ waterSceneRange, soundSceneRange, lightSceneRange ] )
+          majorTicks: createTicks( waterSceneRange, allRanges )
         }, WaveInterferenceConstants.NUMBER_CONTROL_OPTIONS ) )
       }, {
         value: model.soundScene,
         node: new NumberControl( separationString, soundSeparationProperty, soundSceneRange, _.extend( {
           delta: 1,
           valuePattern: cmValueString,
           constrainValue: value => Util.roundToInterval( value, 10 ),
-          majorTicks: createTicks( soundSceneRange, [ waterSceneRange, soundSceneRange, lightSceneRange ] )
+          majorTicks: createTicks( soundSceneRange, allRanges )
         }, WaveInterferenceConstants.NUMBER_CONTROL_OPTIONS ) )
       }, {
         value: model.lightScene,
         node: new NumberControl( separationString, lightSeparationProperty, lightSceneRange, _.extend( {
           delta: 10,
           valuePattern: nmValueString,
           constrainValue: value => Util.roundToInterval( value, 100 ),
-          majorTicks: createTicks( lightSceneRange, [ waterSceneRange, soundSceneRange, lightSceneRange ] )
+          majorTicks: createTicks( lightSceneRange, allRanges )
         }, WaveInterferenceConstants.NUMBER_CONTROL_OPTIONS ) )
       } ] );
     }