Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound will sometimes not work on iOS13 #39

Closed
jbphet opened this issue Oct 3, 2019 · 1 comment
Closed

Sound will sometimes not work on iOS13 #39

jbphet opened this issue Oct 3, 2019 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 3, 2019

There is a change in iOS 13 where we are no longer able to use the user agent the same way we once did in order for the sim to be able to recognize that it is running on iOS 13. As a result, some sims can end up in a state where their sound isn't playing. The currently published versions of "Plinko Probability" and "Forces and Motion Basics" exhibit this problem. Here is the sequence to reproduce the problem on Plinko v1.1.17 (https://phet-dev.colorado.edu/html/plinko-probability/1.1.17/plinko-probability_en.html):

  • launch the sim on an iOS 13 touch-based device (I got one from @KatieWoe, but it didn't have a name sticker on it the way most of the other devices do)
  • without tapping, touch and drag somewhere on the screen that won't interact with anything
  • select the "Intro" screen
  • enable sound using the yellow speaker button
  • drop a ball by pressing the play button

For me at least, this consistently failed to produce any sound, whereas the same sequence without the pre-interaction dragging works fine.

@jbphet jbphet self-assigned this Oct 3, 2019
jbphet added a commit to phetsims/area-builder that referenced this issue Oct 9, 2019
jbphet added a commit to phetsims/area-builder that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/area-model-algebra that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/area-model-decimals that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/area-model-introduction that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/area-model-multiplication that referenced this issue Oct 14, 2019
jbphet added a commit that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/arithmetic that referenced this issue Oct 14, 2019
jbphet added a commit that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/balancing-act that referenced this issue Oct 14, 2019
jbphet added a commit that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/balancing-chemical-equations that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/balloons-and-static-electricity that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/balloons-and-static-electricity that referenced this issue Oct 14, 2019
jbphet added a commit that referenced this issue Oct 14, 2019
jbphet added a commit to phetsims/build-a-fraction that referenced this issue Oct 14, 2019
jonathanolson added a commit to phetsims/fraction-matcher that referenced this issue Oct 25, 2019
jonathanolson added a commit to phetsims/john-travoltage that referenced this issue Oct 25, 2019
jonathanolson added a commit to phetsims/ohms-law that referenced this issue Oct 25, 2019
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Oct 25, 2019
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/balancing-chemical-equations that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/equality-explorer-basics that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/equality-explorer-two-variables that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/forces-and-motion-basics that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/forces-and-motion-basics that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/graphing-lines that referenced this issue Oct 28, 2019
jonathanolson added a commit to phetsims/graphing-slope-intercept that referenced this issue Oct 28, 2019
@jbphet
Copy link
Contributor Author

jbphet commented Nov 5, 2019

The fix has been implemented and deployed in a maintenance release. Closing.

@jbphet jbphet closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant