Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can canAnnounceProperties be TReadOnlyProperty? #99

Closed
jessegreenberg opened this issue Jan 4, 2023 · 3 comments
Closed

Can canAnnounceProperties be TReadOnlyProperty? #99

jessegreenberg opened this issue Jan 4, 2023 · 3 comments

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 4, 2023

In phetsims/friction#314 I wasn't allowed to do this

    const contextResponseUtterance = new Utterance( {
      priority: Utterance.MEDIUM_PRIORITY,
      voicingCanAnnounceProperties: [ voicingManager.voicingFullyEnabledProperty ]
    } );

because voicingFullyEnabledProperty is a TReadOnlyProperty and the canAnnounceProperty API require TProperty, Using a TReadOnlyProperty works and it doesn't look like the Properties of canAnnounceProperties need to be settable. Id like to broaden the API.

@jessegreenberg
Copy link
Contributor Author

I went ahead in the above commit, @zepumph are you OK with this?

@zepumph
Copy link
Member

zepumph commented Jan 4, 2023

Yes very good and very smart. Thanks.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Jan 4, 2023
@jessegreenberg
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants