Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeechSynthesisAnnouncer] convert voices + voicesChangedEmitter to a Property #96

Closed
zepumph opened this issue Dec 1, 2022 · 3 comments
Closed

[SpeechSynthesisAnnouncer] convert voices + voicesChangedEmitter to a Property #96

zepumph opened this issue Dec 1, 2022 · 3 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Dec 1, 2022

Seems like notification + value is that classic recipe for a Property, and @chrisklus and I are running up against this over in phetsims/number-play#188.

tagging our man man @jessegreenberg.
chrisklus added a commit to phetsims/number-play that referenced this issue Dec 1, 2022
@chrisklus
Converted voices to voicesProperty, improve NumberSuiteCommonSpeechSy…
61c2d71 
…nthesisAnnouncer, see phetsims/utterance-queue#96
chrisklus added a commit that referenced this issue Dec 1, 2022
@chrisklus
Converted voices to voicesProperty, improve NumberSuiteCommonSpeechSy…
9a47771 
…nthesisAnnouncer, see #96
chrisklus added a commit to phetsims/joist that referenced this issue Dec 1, 2022
@chrisklus
Converted voices to voicesProperty, improve NumberSuiteCommonSpeechSy…
d5e4ed5 
…nthesisAnnouncer, see phetsims/utterance-queue#96
@jessegreenberg jessegreenberg mentioned this issue Jan 18, 2023
Closed
@zepumph
Copy link
Member Author

zepumph commented Feb 1, 2023

@chrisklus can you give an update on this issue? Where do we stand? Ready for review? Ready to close?

@chrisklus
Copy link
Contributor

Sorry I let this slip, a I think quick review by @jessegreenberg of 9a47771 and phetsims/joist@d5e4ed5 would be really nice. I think the only trouble we caused was already handled in phetsims/number-play#204. Then all set to close if we're looking good.

@chrisklus chrisklus assigned jessegreenberg and unassigned chrisklus Feb 1, 2023
@jessegreenberg
Copy link
Contributor

The changes to utterance-queue and joist make sense to me. Thanks @chrisklus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisklus @jessegreenberg @zepumph