-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utterance.canAnnounceProperty should interrupt the Announcer when it becomes false #77
Comments
…eProperty becomes false, see #77
This was simple enough, the change is working nicely. Tested with Dialogs and ReadingBlocks which now interrupt when closed. |
This is to be reviewed as part of the set from phetsims/scenery#1300 by @zepumph, reopening. And thank you! |
This looks really nice, thanks! Instead of creating a new closure each time we speak, can you attach a bound prototype method, or even a member variable that is set once, and then have a second value like |
Great idea thanks. I went with a bound method. While I was testing this I realized that after #82 we need to do this for both @zepumph can you take a look at this again? |
Looks great, thanks! |
An extension and enhancement of phetsims/scenery/issues/1300, when the Utterance.canSpeakProperty becomes false it should interrupt the Announcer if it is currently being announced.
The text was updated successfully, but these errors were encountered: