Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AriaLiveAnnouncer forever set to readyToAnnounce: false #101

Closed
zepumph opened this issue Feb 1, 2023 · 1 comment
Closed

AriaLiveAnnouncer forever set to readyToAnnounce: false #101

zepumph opened this issue Feb 1, 2023 · 1 comment
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Feb 1, 2023

Reported in phetsims/friction#331

Originally caused by fixes in #88

@jessegreenberg and I found one case in AriaLiveAnnouncer where things can forever fail if the predicate is wrong just before announcing. Fix coming soon!
@zepumph zepumph self-assigned this Feb 1, 2023
zepumph added a commit that referenced this issue Feb 1, 2023
@zepumph
make sure that readyToAnnounce is true again even if predicate fails, #…
9e7c5bb 
…101
@zepumph zepumph mentioned this issue Feb 1, 2023
Closed
@jessegreenberg
Copy link
Contributor

That fix completes this issue, closing.

jessegreenberg pushed a commit that referenced this issue Feb 7, 2023
@zepumph @jessegreenberg
make sure that readyToAnnounce is true again even if predicate fails, #…
76523c3 
…101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph