Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move this sim's 1 screen to FPAF repo #118

Closed
pixelzoom opened this issue Feb 24, 2015 · 3 comments
Closed

move this sim's 1 screen to FPAF repo #118

pixelzoom opened this issue Feb 24, 2015 · 3 comments
Labels
task:S2015R type:i18n

Comments

@pixelzoom
Copy link
Contributor

Related to: phetsims/fluid-pressure-and-flow#266
Prerequisite: #117.

The single screen in this sim is part of FPAF. It would be preferable to have it live there, as is done is all other similar situations (Concentration & Beer's Law Lab, pH Scale: Basics & pH Scale, Molecule Shapes: Basics & Molecule Shape,...)
@pixelzoom pixelzoom mentioned this issue Feb 27, 2015
Closed
@pixelzoom
Copy link
Contributor Author

This needs to be done before the sim is republished, so that translated strings live in FPAF.

@pixelzoom pixelzoom mentioned this issue Sep 10, 2015
Closed
aadish added a commit that referenced this issue Mar 21, 2016
@aadish
re-organizing the code to follow single screen structure, see issue #118
e2a25de
aadish added a commit that referenced this issue Mar 22, 2016
@aadish
removing the code as it is now in fluid pressure and flow, see issue #…
1309e21 
…118
@aadish
Copy link
Contributor

aadish commented Apr 1, 2016

the code has been moved to the fpaf's repo

@aadish
Copy link
Contributor

aadish commented Apr 15, 2016

fixed closing

@aadish aadish closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task:S2015R type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @ariel-phet @aadish