Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated specialAnglesMode variable #29

Closed
jessegreenberg opened this issue Aug 17, 2015 · 4 comments
Closed

Duplicated specialAnglesMode variable #29

jessegreenberg opened this issue Aug 17, 2015 · 4 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

There is a boolean property in ViewProperties called specialAnglesVisible and there is a public variable in TrigTourModel called specialAnglesMode.

Is there a reason to keep both of these variables? It seems that specialAnglesMode can be deleted and the specialAnglesVisible can be passed directly into view elements. This way the view does not have to track two variables for visibility.

@jessegreenberg
Copy link
Contributor Author

I think the same is true for this.labelsVisible in GraphView, which also exists in ViewProperties. Can this public variable be deleted?

@jessegreenberg
Copy link
Contributor Author

Is this also true for radiansDisplayed and specialAnglesOnly in ReadoutNode? It looks like these variables are handled by angleUnitsProperty and specialAnglesVisible in ViewProperties.

@jessegreenberg
Copy link
Contributor Author

trigTourModel.specialAnglesMode deleted in commit 30c233b and replaced with the visibility property in ViewProperties.

jessegreenberg added a commit that referenced this issue Sep 23, 2015
…with labelsVisible in ViewProperties, see issue #29
@jessegreenberg
Copy link
Contributor Author

radiansDisplayed and specialAnglesOnly were deleted and replaced with references to ViewProperties in commit 87ef161. Thats all the cases of repeated variables and ViewProperties. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants