Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright dates #988

Closed
chrisklus opened this issue Feb 18, 2019 · 1 comment
Closed

Update copyright dates #988

chrisklus opened this issue Feb 18, 2019 · 1 comment
Assignees

Comments

@chrisklus
Copy link

Files that have been modified since the beginning of 2019 should have their copyright year updated, if not already done.

I discussed this with @samreid, and he said that perennial/bin/for-each.sh active-runnables "grunt update-copyright-dates" or perennial/bin/for-each.sh active-runnables grunt update-copyright-dates should handle this in one go.

Relevant slack conversation for how I should proceed regarding {{REPO}}-config.js copyright year:

Sam Reid [1:23 PM]
Oh, also, I have a faint memory that one time this script created a syntax error or lint error (didn’t know how to handle a special case or something). So please check lint-everything after changes.
Also, the *-config.js files are now auto-generated and should not be updated by this tool. Last year around this time was a problem--not sure if resolved. If you see anything related to that, take a closer look or reach out to me.
Good luck!

Chris Klusendorf [1:27 PM]
ooh yeah that’s interesting. i was just testing that, and found that running grunt generate-config will not change a date from “2018” to “2018-2019", but instead will just overwrite to “2019”
should I uncheck all of the -config files in the commit dialog and then revert them?

Sam Reid [1:32 PM]
if you run grunt update-copyright-dates without running generate-config, does it change them?

Chris Klusendorf [1:32 PM]
checking…

Sam Reid [1:33 PM]
It seems safe to run grunt update-copyright-dates then run grunt generate-config afterwards.

Chris Klusendorf [1:33 PM]
yeah i’m seeing it as ignoring config

Sam Reid [1:33 PM]
OK that’s even better
Just do grunt update-copyright-dates by itself then
Taking off for a break, good luck!

Chris Klusendorf [1:34 PM]
okay sounds good, so don’t worry about grunt generate-config at all?
thanks!

@chrisklus chrisklus self-assigned this Feb 18, 2019
chrisklus added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/balancing-chemical-equations that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/gene-expression-essentials that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/area-model-multiplication that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/energy-skate-park-basics that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/gravity-force-lab-basics that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/graphing-slope-intercept that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/energy-forms-and-changes that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/forces-and-motion-basics that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/area-model-introduction that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/fractions-mixed-numbers that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/rutherford-scattering that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/proportion-playground that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/capacitor-lab-basics that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/resistance-in-a-wire that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/expression-exchange that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/fraction-comparison that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/molecules-and-light that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/acid-base-solutions that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/area-model-decimals that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/graphing-quadratics that referenced this issue Feb 18, 2019
chrisklus added a commit to phetsims/plinko-probability that referenced this issue Feb 18, 2019
zepumph added a commit to phetsims/trig-tour that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/friction that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/ph-scale that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/ohms-law that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/molarity that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/griddle that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/chains that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/bumper that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/wilder that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/neuron that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/blast that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/tambo that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/twixt that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/vegas that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/joist that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/vibe that referenced this issue Jul 11, 2019
zepumph added a commit to phetsims/sun that referenced this issue Jul 11, 2019
zepumph pushed a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
zepumph added a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
zepumph added a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
zepumph pushed a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
zepumph pushed a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
zepumph pushed a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
chrisklus added a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
marlitas pushed a commit to phetsims/sun that referenced this issue Jun 28, 2022
samreid pushed a commit to phetsims/tambo that referenced this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant