Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are all eslintrc files needed? #950

Closed
zepumph opened this issue Aug 16, 2018 · 1 comment
Closed

Are all eslintrc files needed? #950

zepumph opened this issue Aug 16, 2018 · 1 comment
Assignees
@jonathanolson

Comments

@zepumph
Copy link
Member

zepumph commented Aug 16, 2018

I see 8 .eslintrc files in the project, but I didn't know if we still needed them because of recent work in supporting es6 for all repos.
image

@jonathanolson are these all needed? Or just the one in chipper.
jonathanolson added a commit to phetsims/chipper that referenced this issue Sep 6, 2018
@jonathanolson
Removing unneeded .eslintrc, see phetsims/tasks#950
3cf96e2
jonathanolson added a commit to phetsims/binder that referenced this issue Sep 6, 2018
@jonathanolson
Removing unneeded .eslintrc, see phetsims/tasks#950
c4db37e
jonathanolson added a commit to phetsims/perennial that referenced this issue Sep 6, 2018
@jonathanolson
Removing unneeded .eslintrc, see phetsims/tasks#950
d18e2ba
jonathanolson added a commit to phetsims/rosetta that referenced this issue Sep 6, 2018
@jonathanolson
Removing unneeded .eslintrc, see phetsims/tasks#950
1ef0dc8
jonathanolson added a commit to phetsims/aqua that referenced this issue Sep 6, 2018
@jonathanolson
Removing unneeded .eslintrc, see phetsims/tasks#950
9e247e7
@jonathanolson
Copy link
Contributor

All but the main one should be unneeded. I removed and tested grunt lint-everything and it's working nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @zepumph