Checkbox is one word

[samreid]

Similar to #909 it seems we should make checkbox be one word and avoid "checkBox" or "check box".

Having a uniform custom will make it easier to avoid casing mismatch bugs, and will help us keep a consistent API for sim development and for PhET-iO clients.

[samreid]

Google votes 9,020,000 votes for "check box" and 25,300,000 votes for "checkbox".

[samreid]

Our codebase has 1176 occurrences of heckBox and 603 occurrences of heckbox and 137 occurrences of heck box. So it seems we have been inclined to separate that into two words. I'll search further for ground truth.

[samreid]

Even wikipedia uses both forms in the 2nd paragraph:

though checkbox appears 27 times on that page and "check box" appears 4 times.

[samreid]

On MDN https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement "checkbox" appears 7 times and "check box" appears 0 times.

Likewise the spec refers to checkbox (17 times) and never "check box". Note these are for the HTML element not the scenery component, but it seems we should follow the same logic.

I'm inclined to go with "checkbox". I'll add lint rules and look at updating these.

[samreid]

I noticed that @pixelzoom used "Check box" and CheckBox in sun--it would be good to get him to sign off before we start making changes. @pixelzoom can you please review this issue and comment?

[pixelzoom]

I'm fine with whichever you choose. Is this and #909 primarily motivated by consistency of phetioIDs?

[pixelzoom]

Btw... I've used "check box" mainly for consistency with the UI toolkits I've used in the past. E.g. JCheckBox (Java Swing), QCheckBox (Qt), CheckBox (X/Motif), ...

[samreid]

This issue was discovered while working on making phetioIDs consistent, but I would consider it nearly as important to have a consistent API for our sim development (to avoid case-related undefined bugs).

It seems odd because Java has java.awt.Checkbox but javax.swing.JCheckBox. Why did they make this change?

Iterating through top hits in google search for "checkbox API":

• Android has android.widget.CheckBox
• Angular (also from Google) uses Angular Material checkbox
• Ionic uses "checkbox" https://ionicframework.com/docs/api/components/checkbox/Checkbox/
• Drupal uses Checkbox
• .NET uses CheckBox
• Facebook uses Checkbox

I'm still leaning toward the one-word solution. I'll add a lint rule and start converting usages.

[samreid]

After adding this lint rule, lint-everything reports:

✖ 1353 problems (1353 errors, 0 warnings)

This may take some time unless we can take error-free shortcuts.

[jessegreenberg]

I was able to pull changes on my Windows machine, thanks @samreid. Closing this isssue.