Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting all sims to ES6 #1051

Closed
ariel-phet opened this issue Oct 28, 2020 · 10 comments
Closed

Converting all sims to ES6 #1051

ariel-phet opened this issue Oct 28, 2020 · 10 comments

Comments

@ariel-phet
Copy link

ariel-phet commented Oct 28, 2020

The dev team agreed it would be good for the (code) health of the project to convert all simulations to ES6

HTML5 Sims Conversion Party List

NOTE

@ariel-phet ariel-phet changed the title Converting all sims to ES-6 Converting all sims to ES6 Oct 28, 2020
@Denz1994 Denz1994 self-assigned this Nov 5, 2020
@zepumph zepumph self-assigned this Nov 10, 2020
@chrisklus chrisklus self-assigned this Nov 10, 2020
@Denz1994 Denz1994 removed their assignment Nov 12, 2020
@jessegreenberg jessegreenberg self-assigned this Nov 12, 2020
@chrisklus
Copy link

Assuming this is a continuation of #1050, I checked off what I converted over there.

zepumph added a commit to phetsims/friction that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/coulombs-law that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/ohms-law that referenced this issue Nov 12, 2020
zepumph added a commit to phetsims/molarity that referenced this issue Nov 12, 2020
@zepumph zepumph removed their assignment Nov 12, 2020
zepumph added a commit to phetsims/projectile-motion that referenced this issue Nov 12, 2020
@zepumph
Copy link
Member

zepumph commented Nov 12, 2020

All of my sims have been done. I also checked off optics-lab, which seemed to already be done (classify.py didn't change anything). I also converted Projectile Motion because I was in that sim last.

@samreid
Copy link
Member

samreid commented Nov 19, 2020

@jbphet will review the unchecked sims to see if they need to be updated. He will also look at doing more than one a week, so we can finish sooner rather than later.

@ariel-phet: I'd like to have this polished off early in January.

@zepumph
Copy link
Member

zepumph commented Dec 3, 2020

We reallocated some assignments to try to get this done by next week. Good luck us!

@samreid
Copy link
Member

samreid commented Dec 3, 2020

I finished greenhouse and forces-and-motion basics.

samreid referenced this issue in phetsims/greenhouse-effect Dec 3, 2020
samreid referenced this issue in phetsims/forces-and-motion-basics Dec 3, 2020
@zepumph
Copy link
Member

zepumph commented Dec 4, 2020

neuron complete, see phetsims/neuron#146.

@zepumph zepumph removed their assignment Dec 4, 2020
Denz1994 added a commit to phetsims/number-play that referenced this issue Dec 9, 2020
@Denz1994
Copy link

Denz1994 commented Dec 9, 2020

Number-Play complete.

@jessegreenberg
Copy link

I just finished rutherford-scattering and inverse-square-law-common, removing my assignment.

@jessegreenberg jessegreenberg removed their assignment Dec 10, 2020
@samreid samreid removed their assignment Dec 10, 2020
@pixelzoom
Copy link
Contributor

12/10/2020 dev meeeting

When this issue is done, @jbphet will label open associated issues (e.g. phetsims/phet-info#143) for dev meeting.

@jbphet
Copy link

jbphet commented Dec 12, 2020

I think I've finished off the last ones. We should take one more look at this in developer meeting to make sure we haven't missed anything, and then close this pup.

@jbphet jbphet assigned ariel-phet and unassigned jbphet Dec 12, 2020
@ariel-phet ariel-phet removed their assignment Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants