Skip to content

Commit

Permalink
self-voicing -> voicing in many comments, see phetsims/tasks#1083
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Mar 25, 2021
1 parent 642cd46 commit 10e69fa
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion js/tracking/SaveTestEventsButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class SaveTestEventsButton extends RectangularPushButton {

super( options );

// register for self-voicing output
// register for voicing output
this.addInputListener( new VoicingInputListener( {
onFocusIn: () => {
const response = levelSpeakerModel.collectResponses( BUTTON_OBJECT_RESPONSE );
Expand Down
4 changes: 2 additions & 2 deletions js/view/CustomGestureIntroDialog.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2020, University of Colorado Boulder

/**
* A dialog with a few basic UI components with self-voicing and gesture control to give
* A dialog with a few basic UI components with voicing and gesture control to give
* the user a chance to play with components before interacting with them in the simulation.
* This is intended for use only in prototypes for user interviews. The hope is that providing
* user with a chance to play with components before jumping into the sim will separate
Expand Down Expand Up @@ -119,7 +119,7 @@ class CustomGestureIntroDialog extends Dialog {
// @private {Node}
this.voicingWrapper = voicingWrapper;

// listeners that provide actual self-voicing content on the example components
// listeners that provide actual voicing content on the example components
exampleButton.addInputListener( new VoicingInputListener( {
onFocusIn: () => {
phet.joist.sim.voicingUtteranceQueue.addToBack( testButtonContent );
Expand Down
2 changes: 1 addition & 1 deletion js/view/VoicingLandingDialog.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2020, University of Colorado Boulder

/**
* A Dialog with information about the self-voicing feature, and a button
* A Dialog with information about the voicing feature, and a button
* to enable web speech within the sim. Many browsers do not allow speech synthesis
* until user has made some activation. It is intended for use only in interviews
* that are coming up in November of 2020, so that it is as easy as possilbe to enable this feature
Expand Down
14 changes: 7 additions & 7 deletions js/view/tappiDialogController.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

/**
* Controls landing and intro dialogs as they appear on simulation load. Intended only for interviews
* coming up early November 2020. If self-voicing is enabled, it will show an initial dialog
* coming up early November 2020. If voicing is enabled, it will show an initial dialog
* that has a button to enable web speech, satisfying the requirement by most browsers that
* speech becomes enabled after some user interaction. If custom gestures are enabled, it will
* then continue to another dialog with a few simple UI components to teach the user how to use gestures.
Expand All @@ -24,18 +24,18 @@ class TappiDialogController {
* Creates the dialogs, and adds a listener that creates the dialogs once the sim has been
* constructed (because bounds will be defined then).
* @public
* @param selfVoicingQuickControl
* @param voicingQuickControl
*/
initialize( selfVoicingQuickControl ) {
initialize( voicingQuickControl ) {
assert && assert( phet.joist.sim, 'This controller must be used in a PhET simulation' );

const supportsSelfVoicing = phet.chipper.queryParameters.supportsVoicing;
const supportsVoicing = phet.chipper.queryParameters.supportsVoicing;
const supportsGestureControl = phet.chipper.queryParameters.supportsGestureControl;

// wait to display any initial dialogs until the simulation is complete
phet.joist.sim.isConstructionCompleteProperty.link( complete => {
if ( complete ) {
if ( supportsSelfVoicing ) {
if ( supportsVoicing ) {

// for interviews, you should not be able to do anything outside of these
// dialogs until you go through their content - don't dismiss by tapping
Expand All @@ -51,7 +51,7 @@ class TappiDialogController {
if ( supportsGestureControl ) {
const introDialog = new CustomGestureIntroDialog( {
hideCallback: () => {
selfVoicingQuickControl.focusExpandCollapseButton();
voicingQuickControl.focusExpandCollapseButton();
phet.joist.sim.barrierRectangle.inputEnabled = true;
}
} );
Expand All @@ -60,7 +60,7 @@ class TappiDialogController {
introDialog.focusIntroDescription();
}
else {
selfVoicingQuickControl.focusExpandCollapseButton();
voicingQuickControl.focusExpandCollapseButton();
phet.joist.sim.barrierRectangle.inputEnabled = true;
}
}
Expand Down

0 comments on commit 10e69fa

Please sign in to comment.