Convert types to use PhetioObject

[samreid]

See https://github.com/phetsims/phet-io/issues/1227

[samreid]

Beer's Law Lab is now using PhetioObject, see phetsims/beers-law-lab#219

[samreid]

I've done several, but there are still 30 or so more cases to convert. Tagging @ariel-phet and @kathy-phet so they are aware I'll be working on this.

[jonathanolson]

Regarding 'Node.dispose() call is missing from an overridden dispose method' -- do we want that functionality it PhetioObject?

Presumably yes. Can test in the Scenery playground:

function SubNode() { scenery.Node.call( this ); }
phetCore.inherit( scenery.Node, SubNode, {
  dispose() { console.log( 'oops no super call' ) }
} );
var s = new SubNode();
s.dispose(); // no error

however if it's extremely rare to run into this for all devs, then I'm fine dropping it. Presumably the code could just be moved over to PhetioObject? (I'll test that and see if I run into assertions anywhere).

[jonathanolson]

The other commits (tandem/axon/scenery) look good.

[jonathanolson]

Adding the assertion found that ESPB/ESP Track.js inherits PhetioObject but doesn't do the super dispose.

[samreid]

That sounds like a good catch, do you want to commit the change to PhetioObject?

[pixelzoom]

@samreid will commit the fix, then remove the "blocks" label. Wait on GQ and AM RCs until this is done.

[samreid]

Proposed fixes above and correctly flag problems in Energy Skate Park sims. Flagging @jessegreenberg so he is aware. Reassigned to @jonathanolson to review and close if all is well.

[pixelzoom]

Increasing priority, since this is blocking Graphing Quadratics 1.0 RC. Please notify me when this is closed.

[samreid]

I also mentioned to @pixelzoom that he can review this if he gets to it first.

[pixelzoom]

I'd prefer not to spend time familiarizing myself with this issue. But if @jonathanolson doesn't get to it by Monday morning, I'll dive in.

[jonathanolson]

Looks good to me.

[pixelzoom]

I took a look too, had some questions on Slack, was convinced that this has low risk to cause problems.