You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From #211, there is a TODO in the IOType constructor:
// Validate that parametric types look as expected// REVIEW: What about EmitterIO<> that has no parameter types? See https://github.com/phetsims/tandem/issues/211// if ( this.typeName.includes( '<' ) ) {// assert && assert( this.parameterTypes.length > 0,// 'angle bracket notation is only used for parametric IO Types that have parameter IO Types' );// }
Should EmitterIO that emits nothing be a parametric type (like other EmitterIO) or a non-parametric type (since it doesn't emit anything)? I'm uncertain of the assumptions or ramifications for studio. @zepumph can you please make a recommendation?
If necessary, we could change the default for parameterTypes to null (meaning non-parametric) instead of [] (meaning parametric with 0 parameters).
The text was updated successfully, but these errors were encountered:
I think this is slightly a duplicate of #223. Personally, I don't feel like we need to do anything with this issue. It is more important to me that we make sure that parameterTypes are set correctly, and not that <> are exclusive only to a type with parameters, as it will never be a complete list (like for Function).
From #211, there is a TODO in the IOType constructor:
Should EmitterIO that emits nothing be a parametric type (like other EmitterIO) or a non-parametric type (since it doesn't emit anything)? I'm uncertain of the assumptions or ramifications for studio. @zepumph can you please make a recommendation?
If necessary, we could change the default for
parameterTypes
tonull
(meaning non-parametric) instead of[]
(meaning parametric with 0 parameters).The text was updated successfully, but these errors were encountered: