Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing visibility annotations in IO Types #178

Closed
pixelzoom opened this issue Apr 27, 2020 · 3 comments
Closed

missing visibility annotations in IO Types #178

pixelzoom opened this issue Apr 27, 2020 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

Lots of missing visibility annotations in IO Types and IOImpl inner classes. Recommended to review and fix.

@pixelzoom
Copy link
Contributor Author

I fixed a few in the above commits, but not comprehensive.

@samreid
Copy link
Member

samreid commented Sep 12, 2020

This will no longer be necessary after we adopt the proposal in #211, on hold until that issue is further along.

@samreid
Copy link
Member

samreid commented Sep 26, 2020

IOType now provides these methods as passed-in options, not as overridden methods that require JSDoc. As we move methods like toStateObject to the core types, we will need to remember to add visibility annotations for those, but I think lint rules will help us remember. This issue seems ready to close.

@samreid samreid closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants