fix Disposable, removing disposer and options and using disposeEmitter,

phetsims/axon#433

js/PhetioObject.ts

@@ -27,7 +27,7 @@ import TandemConstants, { PhetioID, PhetioObjectMetadata } from './TandemConstan
 import tandemNamespace from './tandemNamespace.js';
 import IOType from './types/IOType.js';
 import IntentionalAny from '../../phet-core/js/types/IntentionalAny.js';
-import Disposable, { DisposableOptions } from '../../axon/js/Disposable.js';
+import Disposable from '../../axon/js/Disposable.js';
 import LinkableElement from './LinkableElement.js';
 
 // constants
@@ -135,8 +135,7 @@ type SelfOptions = StrictOmit<Partial<PhetioObjectMetadata>, 'phetioTypeName' |
   // sim.screen1.view.upperThermometerNode
   tandemNameSuffix?: string | string[] | null;
 };
-type ParentOptions = DisposableOptions;
-export type PhetioObjectOptions = SelfOptions & ParentOptions;
+export type PhetioObjectOptions = SelfOptions;
 
 type PhetioObjectMetadataKeys = keyof ( StrictOmit<PhetioObjectMetadata, 'phetioTypeName' | 'phetioDynamicElementName'> ) | 'phetioType';
 export type PhetioObjectMetadataInput = Pick<PhetioObject, PhetioObjectMetadataKeys>;
@@ -174,7 +173,7 @@ class PhetioObject extends Disposable {
   public phetioID: PhetioID;
 
   public constructor( options?: PhetioObjectOptions ) {
-    super( options );
+    super();
 
     this.tandem = DEFAULTS.tandem;
     this.phetioID = this.tandem.phetioID;

js/PhetioObjectTests.ts

@@ -57,11 +57,14 @@ QUnit.test( 'PhetioObject end without start', assert => {
   }
 } );
 
-QUnit.test( 'PhetioObject disposer', assert => {
+QUnit.test( 'PhetioObject is a Disposable', assert => {
   const object1 = new PhetioObject();
-  const object2 = new PhetioObject( {
-    disposer: object1
-  } );
+
+  assert.ok( !!object1.disposeEmitter, 'disposeEmitter needed' );
+
+  const object2 = new PhetioObject();
+
+  object1.disposeEmitter.addListener( () => object2.dispose() );
 
   assert.ok( !object1.isDisposed, '1 is not disposed' );
   assert.ok( !object2.isDisposed, '2 is not disposed' );