-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Enhanced Sounds" to "Extra Sounds" #165
Comments
The only spot that wasn't trivial is that "enhancedSound" is in one joist string key: I didn't change the key, but I did change the english value. I don't think we want to change the key, but it is a discrepancy. Otherwise, everything went very smoothly. I tested sims that support this through the menu item (GFL), and also those that do so through the preferences dialog (GFLB and RAP). I also see that phetmarks and package.json files all look good. @jbphet will you please do a spot check here. Thanks |
@zepumph said:
I agree that we shouldn't change the key and should just live with the discrepancy. If we were to change the key, we would need to adjust all existing translations of this string, or basically break the translation of it. So leaving it unchanged seems better. Closing. |
Over in phetsims/joist#744 and https://github.com/phetsims/phet-io/issues/1611, this was determined to be the public name, and with the addition of PhET-iO in preferences, we will want to make the code and tandem names match that decision. Tagging @jbphet so he is aware, but I'm planning to do this work.
The text was updated successfully, but these errors were encountered: