Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Enhanced Sounds" to "Extra Sounds" #165

Closed
zepumph opened this issue Jul 8, 2022 · 2 comments
Closed

Rename "Enhanced Sounds" to "Extra Sounds" #165

zepumph opened this issue Jul 8, 2022 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 8, 2022

Over in phetsims/joist#744 and https://github.com/phetsims/phet-io/issues/1611, this was determined to be the public name, and with the addition of PhET-iO in preferences, we will want to make the code and tandem names match that decision. Tagging @jbphet so he is aware, but I'm planning to do this work.

@zepumph zepumph self-assigned this Jul 8, 2022
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/friction that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/chipper that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/john-travoltage that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/joist that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/qa that referenced this issue Jul 8, 2022
zepumph added a commit to phetsims/phetmarks that referenced this issue Jul 8, 2022
@zepumph
Copy link
Member Author

zepumph commented Jul 8, 2022

The only spot that wasn't trivial is that "enhancedSound" is in one joist string key:

https://github.com/phetsims/joist/blob/728b22344287518c21b673d701381f4abed6a74e/joist-strings_en.json#L32

I didn't change the key, but I did change the english value. I don't think we want to change the key, but it is a discrepancy. Otherwise, everything went very smoothly. I tested sims that support this through the menu item (GFL), and also those that do so through the preferences dialog (GFLB and RAP). I also see that phetmarks and package.json files all look good. @jbphet will you please do a spot check here. Thanks

@jbphet
Copy link
Contributor

jbphet commented Aug 1, 2022

@zepumph said:

I didn't change the key...

I agree that we shouldn't change the key and should just live with the discrepancy. If we were to change the key, we would need to adjust all existing translations of this string, or basically break the translation of it. So leaving it unchanged seems better.

Closing.

@jbphet jbphet closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants