Skip to content

Commit

Permalink
Update documentation, see phetsims/wave-interference#426
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jun 3, 2020
1 parent f14ad63 commit 243f3f9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions js/waves/view/SineWaveGenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,9 @@ class SineWaveGenerator extends SoundGenerator {
}
else if ( !fullyEnabled && this.oscillator !== null ) {

//REVIEW - The comment below seems a little out of context. Cut and paste error? If not, please explain what's fading out and how this matches the timing.
// The parent fades out, we schedule a stop to coincide with the end of the fade out time.
// Turn off the audio, note that there is no need to disconnect the oscillator - this happens automatically
this.oscillator.stop( this.audioContext.currentTime + soundConstants.DEFAULT_LINEAR_GAIN_CHANGE_TIME );
this.oscillator = null;
// note that there is no need to disconnect the oscillator - this happens automatically
}
} );

Expand Down

0 comments on commit 243f3f9

Please sign in to comment.