Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should RectangularStickyToggleButton use the 'pushButton' SoundPlayer? #894

Closed
jessegreenberg opened this issue Sep 25, 2024 · 2 comments
Closed
Assignees

Comments

@jessegreenberg
Copy link
Contributor

While working on #796 we noticed that RectangularStickyToggleButton does not use the same SoundPlayer that RoundStickyToggleButton uses. We were wondering if it should?

I suspect we can copy the pattern used in RoundStickyToggleButton and I am happy to do it, but I wanted to run it by @jbphet first to make sure.

@jbphet
Copy link
Contributor

jbphet commented Sep 26, 2024

Makes sense to me that they should be consistent. I'd so go for it @jessegreenberg. And thanks.

@jbphet jbphet assigned jessegreenberg and unassigned jbphet Sep 26, 2024
jessegreenberg added a commit that referenced this issue Sep 26, 2024
@jessegreenberg
Copy link
Contributor Author

Great, thanks! I added the sound player, and also a required tandem so RectangularStickyToggleButton and RoundStickyToggleButton options are the same. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants