You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We got rid of the defaults and type inference is working well when each createNode creates the same type.
When having the heterogenous elements list like in VariabilityPlotNode, we found microsoft/TypeScript#33664 and microsoft/TypeScript#31617 (comment) and as a result are happy to chock this up to a weirdness of TypeScript lazily inferring the first generic. Typescript has done this by design, and they aren't changing.
We are ready to close and are fine specifying things manually when needing a Supertype for a heterogenous array of elements.
For phetsims/center-and-variability#170, it would be helpful for GroupItemOptions and ToggleNode to know what subtype of Node they are creating.
The text was updated successfully, but these errors were encountered: