-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option voicingHintResponse
does nothing in RectangularRadioButtonGroup
#773
Comments
In the above commits, I used an assertion to test whether any caller was using the Recommended to review this with high priority, in case I've misunderstood something here. |
I think your change is correct and this can be closed. But I found the history in #699 so @zepumph can you please take a look? My understanding is But now that we have nested If that is correct I think this can be closed. |
Yes, totally. Thanks for cleaning up. We can still provide a hint easily through radioButtonOptions because that is a ButtonNode (which includes VoicingOptions already). Thanks |
While working on #740 (cleanup of RectangularRadioButtonGroup), I noticed this option in SelfOptions:
Problems:
(1) This option is defined in VoicingOptions, so has no business being in SelfOptions for RectangularRadioButtonGroup.
(2)
voicingHintResponse
is not used in the implementation of RectangularRadioButtonGroup, and is propagated to super.(3) Super is doing nothing with
voicingHintResponse
. RectangularRadioButtonGroup extends FlowBox, so Voicing (and VoicingOptions) is not part of the heirarchy. Attempting to removevoicingHintResponse
verifies that it's not being inherited from FlowBoxOptions.The text was updated successfully, but these errors were encountered: