Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer-area options to Checkbox. #716

Closed
pixelzoom opened this issue Sep 20, 2021 · 2 comments
Closed

Add pointer-area options to Checkbox. #716

pixelzoom opened this issue Sep 20, 2021 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

For phetsims/fourier-making-waves#165 code review, @jonathanolson had this REVIEW comment in FMWCheckbox:

class FMWCheckbox extends Checkbox {
...
      // pointer area dilation REVIEW: Is this dilation not desired in CHECKBOX_OPTIONS?
      touchAreaXDilation: 6,
      touchAreaYDilation: 6,
      mouseAreaXDilation: 1,
      mouseAreaYDilation: 1
    }, options );

I guess I was trying to avoid Checkbox. But yes, these options would be generally useful in Checkbox. And the lack of these option in Checkbox is the only reason that FMWCheckbox exists. So I'll bit the proverbial bullet and add these options to Checkbox.

@pixelzoom
Copy link
Contributor Author

Done in the above commits, and used in Fourier. I chose to set touchArea and mouseArea even if the option values are zero, because it simplifies the implementation, and (in my experience) designers/QA like to see the pointer areas regardless of whether they've been modified.

@jonathanolson please review with high priority.

@jonathanolson
Copy link
Contributor

Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants