You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
classFMWCheckboxextendsCheckbox{
...
// pointer area dilation REVIEW: Is this dilation not desired in CHECKBOX_OPTIONS?touchAreaXDilation: 6,touchAreaYDilation: 6,mouseAreaXDilation: 1,mouseAreaYDilation: 1},options);
I guess I was trying to avoid Checkbox. But yes, these options would be generally useful in Checkbox. And the lack of these option in Checkbox is the only reason that FMWCheckbox exists. So I'll bit the proverbial bullet and add these options to Checkbox.
The text was updated successfully, but these errors were encountered:
Done in the above commits, and used in Fourier. I chose to set touchArea and mouseArea even if the option values are zero, because it simplifies the implementation, and (in my experience) designers/QA like to see the pointer areas regardless of whether they've been modified.
For phetsims/fourier-making-waves#165 code review, @jonathanolson had this REVIEW comment in FMWCheckbox:
I guess I was trying to avoid Checkbox. But yes, these options would be generally useful in Checkbox. And the lack of these option in Checkbox is the only reason that FMWCheckbox exists. So I'll bit the proverbial bullet and add these options to Checkbox.
The text was updated successfully, but these errors were encountered: