Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider to run on EnabledNode #605

Closed
zepumph opened this issue Jul 17, 2020 · 1 comment
Closed

Slider to run on EnabledNode #605

zepumph opened this issue Jul 17, 2020 · 1 comment
Assignees
@zepumph
Labels
priority:2-high status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 17, 2020

This ended up being useful to do earlier rather than later because of work being done with SliderAPI.js in https://github.com/phetsims/phet-io/issues/1657. Note that I will work on this now, even though #585 is on hold. EnabledNode is in enough components at this point that I feel comfortable adding to Slider, even if we aren't yet pulling the switch on all usages of enabledProperty.
@zepumph zepumph self-assigned this Jul 17, 2020
@zepumph
Copy link
Member Author

zepumph commented Jul 17, 2020

Committed locally. Pushing soon. aqua tests are passing in phet and phet-io brands locally. I will check on CT before the end of the day.

zepumph added a commit to phetsims/tandem that referenced this issue Jul 17, 2020
@zepumph
Add EnabledNode PhET-iO API and support for LinkedElementIO in API va…
6b007dd 
…lidation, mixin EnabledComponentAPIMixin into SliderAPI, phetsims/sun#605
zepumph added a commit to phetsims/axon that referenced this issue Jul 17, 2020
@zepumph
Add EnabledNode PhET-iO API and support for LinkedElementIO in API va…
d7c69ee 
…lidation, mixin EnabledComponentAPIMixin into SliderAPI, phetsims/sun#605
zepumph added a commit that referenced this issue Jul 17, 2020
@zepumph
Slider to run on EnabledNode, #605
748a860
zepumph added a commit that referenced this issue Jul 17, 2020
@zepumph
Add EnabledNode PhET-iO API and support for LinkedElementIO in API va…
5b9a5f1 
…lidation, mixin EnabledComponentAPIMixin into SliderAPI, #605
@zepumph zepumph closed this as completed Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
priority:2-high status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph