Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Orientation.js for values of ariaOrientation #596

Closed
zepumph opened this issue May 26, 2020 · 1 comment
Closed

use Orientation.js for values of ariaOrientation #596

zepumph opened this issue May 26, 2020 · 1 comment
Assignees
@jessegreenberg @zepumph

Comments

@zepumph
Copy link
Member

zepumph commented May 26, 2020

From TODO marked in phetsims/gravity-force-lab-basics#134 (comment):


          // TODO: this should be an enumeration, https://github.com/phetsims/gravity-force-lab-basics/issues/134
          ariaOrientation: 'horizontal', // specify orientation, read by assistive technology

Now we have Orientation.js.

@jessegreenberg, how do you feel about using that here? Assigning to both of us for whoever gets to it first. Let me know if you feel differently.
zepumph added a commit that referenced this issue May 26, 2020
@zepumph
promote TODO to issue, phetsims/gravity-force-lab-basics#134
72340f0 
#596
This was referenced May 26, 2020
Closed
Closed
Closed
zepumph added a commit to phetsims/area-model-common that referenced this issue May 27, 2020
@zepumph
convert Slider.orientation and ariaOrientation to use Orientation, ph…
9dcc1be 
…etsims/sun#597 phetsims/phet-core#76 phetsims/sun#596
zepumph added a commit to phetsims/phet-core that referenced this issue May 27, 2020
@zepumph
convert Slider.orientation and ariaOrientation to use Orientation, ph…
7e5dc05 
…etsims/sun#597 #76 phetsims/sun#596
zepumph added a commit that referenced this issue May 27, 2020
@zepumph
convert Slider.orientation and ariaOrientation to use Orientation, #597
a3d477d 
phetsims/phet-core#76 #596
@zepumph
Copy link
Member Author

zepumph commented May 27, 2020

Implemented above. Closing

@zepumph zepumph closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph