Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of linking checkbox Property in studio #501

Closed
chrisklus opened this issue Apr 23, 2019 · 2 comments
Closed

Opt out of linking checkbox Property in studio #501

chrisklus opened this issue Apr 23, 2019 · 2 comments

Comments

@chrisklus
Copy link
Contributor

When working on phetsims/blackbody-spectrum#83, I needed to instrument the Property that is used for ProjectorModeCheckbox. However, Blackbody Spectrum doesn't pass in its own Property, but links to one that ProjectorModeCheckbox creates if no Property is provided. @zepumph suggested that I instrument that Property within ProjectorModeCheckbox.

Then in that case, since ProjectorModeCheckbox has a child tandem projectorModeEnabledProperty, there is no need for the typical property* link in Studio. So, I'm going to add the option phetioLinkProperty to Checkbox, which defaults to true, and only creates a Property link if it's true.

@chrisklus
Copy link
Contributor Author

chrisklus commented Apr 23, 2019

This worked well. I tested that the linked Property is not appearing in Blackbody Spectrum, but is still appearing in Charges and Fields (Charges and Fields provides its own BooleanProperty to ProjectorModeCheckbox). Assigning to @zepumph for review.

@zepumph
Copy link
Member

zepumph commented Apr 23, 2019

Looks great. Nicely done.

@zepumph zepumph closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants