Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert ComboBox to class #456

Closed
9 tasks done
pixelzoom opened this issue Jan 20, 2019 · 2 comments
Closed
9 tasks done

convert ComboBox to class #456

pixelzoom opened this issue Jan 20, 2019 · 2 comments
Assignees
@pixelzoom
Labels
deprecated:meeting:developer

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 20, 2019 •
edited
Loading

Over in #430, we did a major rewrite of ComboBox, entirely in ES6 except for:

//TODO sun#456 ComboBox cannot use ES6 class until its subtypes do
Node.call( this );
...
//TODO sun#456 ComboBox cannot use ES6 class until its subtypes do
return inherit( Node, ComboBox, {

Searching for "inherit( ComboBox", I see 9 subclasses that would need to be converted:

  • BALANCING_CHEMICAL_EQUATIONS/ToolsComboBox
  • BEERS_LAW_LAB/SolutionComboBox
  • BEERS_LAW_LAB/SoluteComboBox
  • LEAST_SQUARES_REGRESSION/DataSetComboBox
  • MASSES_AND_SPRING/GravityComboBox
  • MOLARITY/SoluteComboBox
  • MOLECULE_POLARITY/RealMoleculesComboBox
  • PH_SCALE/SoluteComboBox
  • UNIT_RATES/ShoppingSceneComboBox

Opinions on whether I should do this conversion?
@pixelzoom pixelzoom self-assigned this Jan 20, 2019
pixelzoom added a commit that referenced this issue Jan 20, 2019
@pixelzoom
TODO #456
608faba
@pixelzoom
Copy link
Contributor Author

Since 7 of the 9 subtypes are in my sims, I think I'll go for it.

pixelzoom added a commit to phetsims/balancing-chemical-equations that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
f04bd5b
pixelzoom added a commit to phetsims/least-squares-regression that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
43237a2
pixelzoom added a commit to phetsims/masses-and-springs that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
ec22992
pixelzoom added a commit to phetsims/molecule-polarity that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
a58e799
pixelzoom added a commit to phetsims/beers-law-lab that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
407b116
pixelzoom added a commit to phetsims/unit-rates that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
92ec0fc
pixelzoom added a commit to phetsims/ph-scale that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
d84c6cf
pixelzoom added a commit to phetsims/molarity that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, phetsims/sun#456
68c2b89
pixelzoom added a commit that referenced this issue Jan 20, 2019
@pixelzoom
convert ComboBox and its subtypes to class, #456
2ab8dad
@pixelzoom
Copy link
Contributor Author

Done. Notified developers on Slack. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
deprecated:meeting:developer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom