review ComboBox in all sims to verify that they look "good"

[pixelzoom]

In #430 (comment), @jessegreenberg noted:

The look in sims slightly changed because the option defaults and behavior for margins changed and the default for cornerRadius was reduced by half. I reviewed bending-light and molecule-shapes and the differences seem OK to me but want to make sure this is acceptable.

I replied:

FYI, trying to make things look exact is a rathole that I did go down. But there were so many things that made that difficult to accomplish. There were something about layout that were just wrong to begin with inside ComboBox and its components. The options for margins were overly complicated and were changed dramatically. And some of the defaults didn't really make senses as defaults; they were probably the values used by the sim that birthed ComboBox (BLL?) Anyway... I examined every ComboBox in every sim (which took forever) and verified that they all look reasonable. (Some btw did not look great before the changes.) If we want everything to look exactly the same as it did before the changes, that's going to take an undeterminable amount of time.

But I think this is a rathole that I should go down again, given how extensive the changes have been to ComboBox. So I'm going to review (and potentially adjust) all ComboBoxes in all sims.

Sims to review:

• balancing-chemical-equations
• beers-law-lab, concentration
• bending-light
• circuit-construction-kit-black-box-study
• energy-skate-park
• fluid-pressure-and-flow
• gas-properties
• interaction-dash-board (research)
• least-squares-regression
• masses-and-springs
• molarity
• molecule-polarity
• molecule-shapes
• pendulum-lab
• ph-scale, phet-scale-basics
• projectile-motion
• states-of-matter
• tambo (demo)
• twixt (demo)
• unit rates
• wave-interference

[pixelzoom]

@ariel-phet gave me the go ahead, said this sounds worth doing. But there is no need to make ComboBoxes look exactly as before (good, because that's not even possible). Making it look "good" is important, and I can use my judgement on what is "good".

I've done this for my sims, but still need to visit other sims.

[pixelzoom]

balancing-chemical-equations:

[pixelzoom]

beers-law-lab, concentration:

[pixelzoom]

bending-light:

[pixelzoom]

circuit-construction-kit-black-box-study:

[pixelzoom]

energy-skate-park:

[pixelzoom]

fluid-pressure-and-flow:

[pixelzoom]

gas-properties:

[pixelzoom]

interaction-dashboard:

[pixelzoom]

least-squares-regression:

[pixelzoom]

masses-and-spring:

[pixelzoom]

molarity:

[pixelzoom]

molecule-polarity:

[pixelzoom]

molecules-shapes:

[pixelzoom]

pendulum-lab:

[pixelzoom]

ph-scale, ph-scale-basics:

[pixelzoom]

projectile-motion:

[pixelzoom]

states-of-matter:

[pixelzoom]

tambo (demo):

[pixelzoom]

twixt (demo):

[pixelzoom]

unit-rates:

[pixelzoom]

wave-interference:

[pixelzoom]

@ariel-phet I inspected all of the ComboBoxes in all sims, and only adjusted bending-light and energy-skate-park. Please look through the screenshots above. If you see any that you'd like to adjust, let me know. Otherwise please close this issue.

[pixelzoom]

@ariel-phet ping. I'd like to get the ComboBox work wrapped up.

[ariel-phet]

All looks good to me. Closing