Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate scenery events through slider startDrag and endDrag #441

Closed
jbphet opened this issue Jan 10, 2019 · 1 comment
Closed

Propagate scenery events through slider startDrag and endDrag #441

jbphet opened this issue Jan 10, 2019 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jan 10, 2019

Slider.js takes options that allow clients to specify startDrag and endDrag methods. The scenery input event is not currently passed through to these methods. This is causing an issue in Resistance in a Wire where the isn't able to tell if a slider was moved due to a mouse/touch event versus keyboard interaction (see phetsims/resistance-in-a-wire#204). The slider code should be modified so that the scenery event is passed through to these methods.

@jbphet
Copy link
Contributor Author

jbphet commented Mar 22, 2019

I've added these a couple of months ago and it is working in the specific test case for RIAW, and doesn't seem to have caused any issues elsewhere. This is simple enough that I don't think it requires review.
Closing.

@jbphet jbphet closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant