-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComboBox: add align option #419
Comments
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
The I tested with Randomly assigned to @jessegreenberg to review, which works out nicely since my primary concern is breaking a11y. |
Changes look good @pixelzoom. I tested a few other comboboxes, the option worked as expected, focus highlights were correct and screen reader output was not changed. Closing. |
Reopening. This feature was broken during #430. |
ComboBox items are left aligned, with no option to do otherwise.
When the items are numbers, it would better to right align them. For example, here's how the Collision Counter currently looks in Gas Properties:
Add
align
option, with values 'left' (default), 'right', 'center'.align
should apply to both the popup list and the current value displayed on the button.The text was updated successfully, but these errors were encountered: