-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a consistent default for cornerRadius #376
Comments
Sounds like a good idea. I don't have any preference on what that value is. |
Changing the current defaults would change sims - would we plan to keep all "current" behavior (adding corner radii overloads in many places)? |
Currently: Panel is 10, AccordionBox is 3. |
8/23/18 dev meeting consensus: I will change AccordionBox default to |
…sun#376 Signed-off-by: Chris Malley <[email protected]>
…sun#376 Signed-off-by: Chris Malley <[email protected]>
…sun#376 Signed-off-by: Chris Malley <[email protected]>
…sun#376 Signed-off-by: Chris Malley <[email protected]>
…sun#376 Signed-off-by: Chris Malley <[email protected]>
I changed AccordionBox's default to I only had to explicitly set area-builder @jbphet Closing. |
Signed-off-by: Chris Malley <[email protected]>
AccordionBox and Panel have different values for their
cornerRadius
options. In the past few sims that I've worked on, we used both AccordionBox and Panel, and this difference forced me to set a consistentcornerRadius
. Rather than continue to do this, let's choose a consistent default.The text was updated successfully, but these errors were encountered: