Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a consistent default for cornerRadius #376

Closed
pixelzoom opened this issue Aug 13, 2018 · 5 comments
Closed

use a consistent default for cornerRadius #376

pixelzoom opened this issue Aug 13, 2018 · 5 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

AccordionBox and Panel have different values for their cornerRadius options. In the past few sims that I've worked on, we used both AccordionBox and Panel, and this difference forced me to set a consistent cornerRadius. Rather than continue to do this, let's choose a consistent default.

@zepumph
Copy link
Member

zepumph commented Aug 16, 2018

Sounds like a good idea. I don't have any preference on what that value is.

@jonathanolson
Copy link
Contributor

Changing the current defaults would change sims - would we plan to keep all "current" behavior (adding corner radii overloads in many places)?

@pixelzoom
Copy link
Contributor Author

Currently: Panel is 10, AccordionBox is 3.

@pixelzoom
Copy link
Contributor Author

8/23/18 dev meeting consensus: I will change AccordionBox default to cornerRadius: 10, and make all existing call sites set cornerRadius: 3, so that behavior of sims is unchanged.

pixelzoom added a commit to phetsims/least-squares-regression that referenced this issue Aug 24, 2018
pixelzoom added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Aug 24, 2018
pixelzoom added a commit to phetsims/sugar-and-salt-solutions that referenced this issue Aug 24, 2018
pixelzoom added a commit to phetsims/build-an-atom that referenced this issue Aug 24, 2018
pixelzoom added a commit to phetsims/area-builder that referenced this issue Aug 24, 2018
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 24, 2018

I changed AccordionBox's default to cornerRadius: 10.

I only had to explicitly set cornerRadius: 3 in 5 sims, FYI responsible developers mentioned here:

area-builder @jbphet
build-an-atom @jbphet
isotopes-and-atomic-mass @jbphet
least-squares-regression @jonathanolson
sugar-and-salt-solutions (unpublished) @samreid

Closing.

pixelzoom added a commit that referenced this issue Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants