Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arch support to HSlider #161

Closed
samreid opened this issue Mar 6, 2015 · 4 comments
Closed

Add arch support to HSlider #161

samreid opened this issue Mar 6, 2015 · 4 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Mar 6, 2015

HSlider will will need arch support for phetsims/concentration#34

@samreid samreid self-assigned this Mar 6, 2015
samreid added a commit that referenced this issue Mar 6, 2015
@samreid
Copy link
Member Author

samreid commented Mar 6, 2015

Fixed above, but should be reviewed by @pixelzoom since the start drag method was changed to avoid computing values when disabled.

@samreid samreid assigned pixelzoom and unassigned samreid Mar 6, 2015
@pixelzoom
Copy link
Contributor

SimpleDragHandler.start looks fine.

@pixelzoom pixelzoom assigned samreid and unassigned pixelzoom Mar 9, 2015
@samreid
Copy link
Member Author

samreid commented Mar 11, 2015

Anything else to do for this issue before it can be closed @pixelzoom ?

@samreid samreid assigned pixelzoom and unassigned samreid Mar 11, 2015
@pixelzoom
Copy link
Contributor

Nothing else to do for arch support. Whether there's anything to do for together support will depend on whether we need to "play back" highlighting of the knob, etc. I'll close this issue and assume that together will be addressed more generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants