Skip to content

Commit

Permalink
Revert "make HSlider focusHighlightLayerable, phetsims/scenery-phet#341"
Browse files Browse the repository at this point in the history
This reverts commit de8add7.
  • Loading branch information
zepumph committed Oct 25, 2017
1 parent 12dadd9 commit f309a64
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions js/HSlider.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ define( function( require ) {
keyboardStep: ( range.max - range.min ) / 20,
shiftKeyboardStep: ( range.max - range.min ) / 100,
pageKeyboardStep: ( range.max - range.min ) / 10,
focusHighlightLineWidth: 4,
enabledProperty: null, // see below
enabledRangeProperty: null, // see below
focusHighlightLayerable: true,

// phet-io
tandem: Tandem.tandemRequired(),
Expand Down Expand Up @@ -269,7 +269,6 @@ define( function( require ) {

// a11y - custom focus highlight that surrounds and moves with the thumb
this.focusHighlight = new FocusHighlightFromNode( thumb );
this.addChild( this.focusHighlight );

// a11y - arbitrary value, but required for screen readers to manage change events correctly
this.setAccessibleAttribute( 'step', 0.1 );
Expand Down Expand Up @@ -396,13 +395,13 @@ define( function( require ) {
if ( Input.isRangeKey( event.keyCode ) ) {
options.endDrag();
firstKeyDown = true;
}
}
}
},
change: function( event ) {

if ( self.enabledProperty.get() ) {

// it is possible that the user agent (particularly VoiceOver) will initiate a change event directly without
// going through keydown. In that case, handle the change depending on which direction the user tried to go
var inputValue = event.target.value;
Expand Down

1 comment on commit f309a64

@pixelzoom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted because it broke phetsims/hookes-law#47

Please sign in to comment.