move tandemNameSuffix: 'Button' to ButtonNode, phetsims/tandem#310

js/buttons/BooleanRectangularToggleButton.ts

@@ -36,8 +36,7 @@ export default class BooleanRectangularToggleButton extends RectangularToggleBut
 
     const options = optionize<BooleanRectangularToggleButtonOptions, SelfOptions, RectangularToggleButtonOptions>()( {
       content: content,
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     super( booleanProperty, false, true, options );

js/buttons/BooleanRoundToggleButton.ts

@@ -27,15 +27,14 @@ class BooleanRoundToggleButton extends RoundToggleButton<boolean> {
    * @param booleanProperty
    * @param trueNode - shown when booleanProperty is true
    * @param falseNode - shown when booleanProperty is false
-   * @param providedOptions?
+   * @param [providedOptions]
    */
   public constructor( booleanProperty: Property<boolean>, trueNode: Node, falseNode: Node,
                       providedOptions?: BooleanRoundToggleButtonOptions ) {
 
     const options = optionize<BooleanRoundToggleButtonOptions, SelfOptions, RoundToggleButtonOptions>()( {
       content: null,
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     const toggleNode = new BooleanToggleNode( booleanProperty, trueNode, falseNode, {

js/buttons/ButtonNode.ts

@@ -154,6 +154,7 @@ export default class ButtonNode extends Sizable( Voicing( Node ) ) {
       tagName: 'button',
 
       // phet-io
+      tandemNameSuffix: 'Button',
       visiblePropertyOptions: { phetioFeatured: true },
       phetioEnabledPropertyInstrumented: true // opt into default PhET-iO instrumented enabledProperty
     }, providedOptions );

js/buttons/RectangularMomentaryButton.ts

@@ -36,8 +36,7 @@ export default class RectangularMomentaryButton<T> extends RectangularButton {
   public constructor( property: TProperty<T>, valueOff: T, valueOn: T, providedOptions?: RectangularMomentaryButtonOptions ) {
 
     const options = optionize<RectangularMomentaryButtonOptions, SelfOptions, RectangularButtonOptions>()( {
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     // Note it shares a tandem with this, so the emitter will be instrumented as a child of the button

js/buttons/RectangularPushButton.ts

@@ -36,8 +36,7 @@ export default class RectangularPushButton extends RectangularButton {
 
     const options = optionize<RectangularPushButtonOptions, SelfOptions, SuperOptions>()( {
       soundPlayer: pushButtonSoundPlayer,
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     // Save the listener and add it after creating the button model.  This is done so that

js/buttons/RectangularToggleButton.ts

@@ -36,7 +36,7 @@ export default class RectangularToggleButton<T> extends RectangularButton {
    * @param property - axon Property that can be either valueOff or valueOn
    * @param valueOff - value when the button is in the off state
    * @param valueOn - value when the button is in the on state
-   * @param providedOptions?
+   * @param [providedOptions]
    */
   public constructor( property: Property<T>, valueOff: T, valueOn: T, providedOptions?: RectangularButtonOptions ) {
 
@@ -48,8 +48,7 @@ export default class RectangularToggleButton<T> extends RectangularButton {
 
       // phet-io support
       tandem: Tandem.REQUIRED,
-      phetioFeatured: true,
-      tandemNameSuffix: 'Button'
+      phetioFeatured: true
     }, providedOptions );
 
     // Note it shares a tandem with this, so the emitter will be instrumented as a child of the button

js/buttons/RoundMomentaryButton.ts

@@ -35,8 +35,7 @@ export default class RoundMomentaryButton<T> extends RoundButton {
   public constructor( property: TProperty<T>, valueOff: T, valueOn: T, providedOptions?: RoundMomentaryButtonOptions ) {
 
     const options = optionize<RoundMomentaryButtonOptions, SelfOptions, RoundButtonOptions>()( {
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     // Note it shares a tandem with this, so the emitter will be instrumented as a child of the button

js/buttons/RoundPushButton.ts

@@ -37,8 +37,7 @@ export default class RoundPushButton extends RoundButton {
 
     const options = optionize<RoundPushButtonOptions, SelfOptions, SuperOptions>()( {
       soundPlayer: pushButtonSoundPlayer,
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     // Save the listener and add it after creating the button model. This is done so that

js/buttons/RoundStickyToggleButton.ts

@@ -42,8 +42,7 @@ export default class RoundStickyToggleButton<T> extends RoundButton {
       soundPlayer: pushButtonSoundPlayer,
 
       // RoundButtonOptions
-      tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button'
+      tandem: Tandem.REQUIRED
     }, providedOptions );
 
     // Note it shares a tandem with this, so the emitter will be instrumented as a child of the button

js/buttons/RoundToggleButton.ts

@@ -48,8 +48,7 @@ export default class RoundToggleButton<T> extends RoundButton {
 
       // phet-io support
       tandem: Tandem.REQUIRED,
-      phetioFeatured: true,
-      tandemNameSuffix: 'Button'
+      phetioFeatured: true
     }, providedOptions );
 
     // Note it shares a tandem with this, so the emitter will be instrumented as a child of the button

js/buttons/TextPushButton.ts

@@ -38,7 +38,6 @@ export default class TextPushButton extends RectangularPushButton {
 
       // RectangularPushButtonOptions
       tandem: Tandem.REQUIRED,
-      tandemNameSuffix: 'Button',
       innerContent: string
     }, providedOptions );