set focusable:true in ComboBoxListItemNode options, #445

phetsims · Jan 20, 2019 · e07398c · e07398c
1 parent 03b8421
commit e07398c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/js/ComboBoxListBox.js b/js/ComboBoxListBox.js
@@ -185,12 +185,8 @@ define( require => {
                   // a11y - keep this PDOM attribute in sync
                   this.updateActiveDescendant( nextListItemNode );
 
-                  // clear focus for previous item
-                  this.focusedItemNode.focusable = false;
-
                   // set focus for next item
                   this.focusedItemNode = nextListItemNode;
-                  this.focusedItemNode.focusable = true; //TODO sun#314 why do we need to set focusable=true?
                   this.focusedItemNode.focus();
                   break;
                 }
@@ -236,17 +232,10 @@ define( require => {
           const listItemNode = this.listItemNodes[ i ];
           if ( this.property.value === listItemNode.item.value ) {
             this.focusedItemNode = listItemNode;
-            this.focusedItemNode.focusable = true;
             this.focusedItemNode.focus();
           }
         }
       }
-      else if ( this.focusedItemNode ) {
-
-        // listbox is invisible, clear focus
-        this.focusedItemNode.focusable = false;
-        this.focusedItemNode = null;
-      }
     }
 
     // TODO: sun#314 we don't likely need this anymore

diff --git a/js/ComboBoxListItemNode.js b/js/ComboBoxListItemNode.js
@@ -43,6 +43,7 @@ define( require => {
 
         // a11y
         tagName: 'li',
+        focusable: true,
         ariaRole: 'option',
         a11yLabel: null