make AccessibleNumberSpinner an input of type range with spinbutton a…

…ria-roledescription, #497
phetsims · Apr 24, 2019 · c88288b · c88288b
1 parent cd8e042
commit c88288b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/js/accessibility/AccessibleNumberSpinner.js b/js/accessibility/AccessibleNumberSpinner.js
@@ -97,8 +97,9 @@ define( function( require ) {
           assert && assert( options.inputType === undefined, 'AccessibleNumberSpinner sets inputType' );
           optionsToMutate.inputType = 'range';
 
-          assert && assert( options.ariaRole === undefined, 'AccessibleNumberSpinner sets ariaRole' );
-          optionsToMutate.ariaRole = 'spinbutton';
+          // TODO: we might use this instead of a role description, see https://github.com/phetsims/sun/issues/497
+          // assert && assert( options.ariaRole === undefined, 'AccessibleNumberSpinner sets ariaRole' );
+          // optionsToMutate.ariaRole = 'spinbutton';
 
           this.mutate( optionsToMutate );
 
@@ -152,8 +153,7 @@ define( function( require ) {
           // number spinners should only deal in integers
           this.setAccessibleAttribute( 'step', 1 );
 
-          // TODO: we might use this instead of an actual role, see https://github.com/phetsims/sun/issues/497
-          // this.setAccessibleAttribute( 'aria-roledescription', 'spinbutton' );
+          this.setAccessibleAttribute( 'aria-roledescription', 'spinbutton' );
 
           // a callback that is added and removed from the timer depending on keystate
           var downCallback = null;