Changing Property to StringProperty, see phetsims/chipper#1310

phetsims · Aug 29, 2022 · a8a5b6a · a8a5b6a
1 parent cf27582
commit a8a5b6a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/js/Dialog.ts b/js/Dialog.ts
@@ -293,7 +293,7 @@ export default class Dialog extends Popupable( Panel, 1 ) {
     let voicingNameMultilink: UnknownMultilink;
     if ( options.closeButtonVoicingDialogTitle ) {
       const titleProperty = typeof options.closeButtonVoicingDialogTitle === 'string' ? new TinyProperty( options.closeButtonVoicingDialogTitle ) : options.closeButtonVoicingDialogTitle;
-      voicingNameMultilink = Multilink.multilink( [ sunStrings.a11y.titleClosePatternProperty, titleProperty ], ( titleClosePattern, titleString ) => {
+      voicingNameMultilink = Multilink.multilink( [ sunStrings.a11y.titleClosePatternStringProperty, titleProperty ], ( titleClosePattern, titleString ) => {
         closeButton.voicingNameResponse = StringUtils.fillIn( titleClosePattern, {
           title: titleString
         } );

diff --git a/js/sunStrings.ts b/js/sunStrings.ts
@@ -11,17 +11,17 @@ import sun from './sun.js';
 type StringsType = {
   'sun': {
     'title': string;
-    'titleProperty': TReadOnlyProperty<string>;
+    'titleStringProperty': TReadOnlyProperty<string>;
   };
   'a11y': {
     'numberSpinnerRoleDescription': string;
-    'numberSpinnerRoleDescriptionProperty': TReadOnlyProperty<string>;
+    'numberSpinnerRoleDescriptionStringProperty': TReadOnlyProperty<string>;
     'close': string;
-    'closeProperty': TReadOnlyProperty<string>;
+    'closeStringProperty': TReadOnlyProperty<string>;
     'closed': string;
-    'closedProperty': TReadOnlyProperty<string>;
+    'closedStringProperty': TReadOnlyProperty<string>;
     'titleClosePattern': string;
-    'titleClosePatternProperty': TReadOnlyProperty<string>;
+    'titleClosePatternStringProperty': TReadOnlyProperty<string>;
   }
 };