Skip to content

Commit

Permalink
stick with using Emitter when list box fires, #405
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 22, 2019
1 parent 499f06b commit 4eacb80
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/ComboBoxListBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ define( require => {

}, options );

// TODO sun#405 It seems it would be better to use FireListener on each ComboBoxListItemNode
const firedEmitter = new Emitter( {
argumentTypes: [ { validValue: Event } ],

// Pops down the list box and sets the property.value to match the chosen item.
listener: event => {

const listItemNode = event.currentTarget;
Expand Down

0 comments on commit 4eacb80

Please sign in to comment.