Skip to content

Commit

Permalink
TODO for #463
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 22, 2019
1 parent 152f676 commit 2b59a91
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions js/ComboBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ define( require => {

this.mutate( options );

// Clicking on the button toggles visibility of the list
// Clicking on the button toggles visibility of the list box
this.button.addListener( () => {
if ( !this.listBox.visible ) {
this.showListBox();
Expand All @@ -165,11 +165,10 @@ define( require => {
}
} );

//TODO sun#462 integrate this with above button listener, to eliminate order dependency
// Handle button clicks, for a11y
this.button.addInputListener( {
click: () => {

//TODO sun#314 order dependency, requires that button's listener has called showList
if ( this.listBox.visible ) {
this.listBox.focus();
}
Expand Down

0 comments on commit 2b59a91

Please sign in to comment.