a11y instrumentation in RoundButtonView, removed from subtypes, see #459

phetsims · Jan 23, 2019 · 1ee367d · 1ee367d
1 parent 2055418
commit 1ee367d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 13 deletions.
diff --git a/js/buttons/RoundButtonView.js b/js/buttons/RoundButtonView.js
@@ -72,7 +72,10 @@ define( function( require ) {
       // on the button's state.  This can be a stock strategy from this file,
       // or custom.  To create a custom one, model it off of the stock
       // version(s) defined in this file.
-      contentAppearanceStrategy: RoundButtonView.FadeContentWhenDisabled
+      contentAppearanceStrategy: RoundButtonView.FadeContentWhenDisabled,
+
+      // a11y
+      tagName: 'button'
     }, options );
 
     Node.call( this );

diff --git a/js/buttons/RoundPushButton.js b/js/buttons/RoundPushButton.js
@@ -29,10 +29,7 @@ define( function( require ) {
   function RoundPushButton( options ) {
 
     options = _.extend( {
-      tandem: Tandem.required,
-
-      // a11y
-      tagName: 'button'
+      tandem: Tandem.required
     }, options );
 
     var self = this;

diff --git a/js/buttons/RoundStickyToggleButton.js b/js/buttons/RoundStickyToggleButton.js
@@ -31,10 +31,7 @@ define( function( require ) {
 
     options = _.extend( {
       tandem: Tandem.required,
-      phetioType: ToggleButtonIO,
-
-      // a11y
-      tagName: 'button'
+      phetioType: ToggleButtonIO
     }, options );
 
     // @private (read-only)

diff --git a/js/buttons/RoundToggleButton.js b/js/buttons/RoundToggleButton.js
@@ -30,10 +30,7 @@ define( function( require ) {
     // Tandem support
     options = _.extend( {
       tandem: Tandem.required,
-      phetioType: ToggleButtonIO,
-
-      // a11y
-      tagName: 'button'
+      phetioType: ToggleButtonIO
     }, options );
 
     // @private (read-only)