make ComboBoxItemNode Tandem.require, #55

Signed-off-by: Chris Malley <[email protected]>
phetsims · Jan 7, 2019 · 1cd60a2 · 1cd60a2
1 parent e37522c
commit 1cd60a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/js/ComboBoxItem.js b/js/ComboBoxItem.js
@@ -11,7 +11,6 @@ define( require => {
   // modules
   const Node = require( 'SCENERY/nodes/Node' );
   const sun = require( 'SUN/sun' );
-  const Tandem = require( 'TANDEM/Tandem' );
 
   class ComboBoxItem {
 
@@ -24,11 +23,6 @@ define( require => {
 
       assert && assert( node instanceof Node, 'invalid node: ' + node );
 
-      //TODO sun#430 Can this check be removed? Or should this check live somewhere else?
-      if ( Tandem.validationEnabled() ) {
-        assert && assert( options && options.tandemName, 'for instrumented sims, tandemName is required' );
-      }
-
       options = _.extend( {
 
         // phet-io

diff --git a/js/ComboBoxItemNode.js b/js/ComboBoxItemNode.js
@@ -37,7 +37,7 @@ define( require => {
         xMargin: 6,
 
         // phet-io
-        tandem: Tandem.optional,
+        tandem: Tandem.required,
 
         // a11y
         tagName: 'li',
@@ -76,7 +76,7 @@ define( require => {
         this.innerContent = item.a11yLabel; //TODO #314 is this correct? if so, document why.
       }
 
-      //TODO #314 this is marked private, but is assigned above, it should be set via options or a setter method
+      //TODO #314 This is marked private, but is assigned in ComboBox. It should be set via options or a setter method.
       // @private {null|function} - listener called when button clicked with AT
       this.a11yClickListener = null;