Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hiding Epsilon and/or Sigma controls to client guide #341

Closed
KatieWoe opened this issue Aug 18, 2020 · 3 comments
Closed

Add hiding Epsilon and/or Sigma controls to client guide #341

KatieWoe opened this issue Aug 18, 2020 · 3 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#531.
Related to client request:

Hide the interaction strength slider

and these properties were given to do this:

statesOfMatter.phaseChangesScreen.view.moleculesControlPanel.interactionStrengthSlider.visibleProperty
statesOfMatter.interactionScreen.view.atomsControlPanel.interactionStrengthSlider.visibleProperty

In both these cases, the Epsilon control in the interactive graph allows changes without those sliders. This should be updated in the guide. I don't believe the Sigma control is relevant in the guide, but just in case.

@arouinfar
Copy link
Contributor

Thanks @KatieWoe. This was a good find. I added the epsilon controls to the SOM guide (irrelevant to SOMB). Since the client didn't have any sigma-related requests, I didn't add the sigma graph controls to the guide.

Back to you @jbphet.

@jbphet
Copy link
Contributor

jbphet commented Aug 19, 2020

changes cherry-picked to the 1.2 branch

@KatieWoe
Copy link
Contributor Author

Looks good in rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants