-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the phase diagram out of PhaseDiagramAccordionBox #313
Comments
I did some work on this and improved the situation, but in the process I realized that there is way too much coupling between the I started on this refactor, but it was taking more time than I could reasonably justify. I'm going to leave it at this for now, and if there is ever a need to do more generalization of this diagram, I or someone else will need to take it from here. |
Unassigning, since it is unlikely that I'll have any time to work on it in the foreseeable future. |
When this is done, care must be taken to make sure that it does not alter the phet-io API. |
PhaseDiagramAccordionBox
builds the whole phase diagram inside of an accordion box, which works, but isn't a very good separation of concerns. I should pull the phase diagram into its own node which is then constructed and included in the accordion box.The text was updated successfully, but these errors were encountered: