Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from inherit to class #304

Closed
samreid opened this issue Jun 29, 2020 · 3 comments
Closed

Convert from inherit to class #304

samreid opened this issue Jun 29, 2020 · 3 comments
Assignees
@jbphet
Labels
dev:code-review

Comments

@samreid
Copy link
Member

samreid commented Jun 29, 2020

During #299 I noticed the simulations have 42+ usages of inherit instead of class. I didn't see another issue for this.
@jbphet
Copy link
Contributor

jbphet commented Jun 30, 2020

I believe this is covered under phetsims/phet-core#82.

Regardless, I'm going to defer this for now and ask at the next dev meeting about whether converting this and other sims from inherit to class is a priority.

jbphet added a commit that referenced this issue Jun 30, 2020
@jbphet
converted to an ES6 class, see #304, phetsims/phet-core#82, and #306
0c66051
@jbphet
Copy link
Contributor

jbphet commented Jul 2, 2020

We discussed this issue as well as the general idea of migrating all files from inherit to class in today's developer meeting and decide to move forward with converting SOM, but not to proactively convert other sims. Un-deferring.

jbphet added a commit that referenced this issue Jul 15, 2020
@jbphet
migrated files from inherit to class, see #304
685d2ee
jbphet added a commit that referenced this issue Jul 15, 2020
@jbphet
migrated files from inherit to class, see #304
fdf8fe4
jbphet added a commit that referenced this issue Jul 16, 2020
@jbphet
migrated files from inherit to class, see #304
2244247
jbphet added a commit that referenced this issue Jul 16, 2020
@jbphet
migrated files from inherit to class, see #304
dab71de
jbphet added a commit that referenced this issue Jul 16, 2020
@jbphet
migrated files from inherit to class, see #304
ed122e6
jbphet added a commit that referenced this issue Jul 22, 2020
@jbphet
migrated files from inherit to class, see #304, addressed review comm…
2a509e1 
…ents, see #299
jbphet added a commit to phetsims/states-of-matter-basics that referenced this issue Jul 22, 2020
@jbphet
more es6 migration, see phetsims/states-of-matter#304
7ecb610
jbphet added a commit to phetsims/atomic-interactions that referenced this issue Jul 22, 2020
@jbphet
more es6 migration, see phetsims/states-of-matter#304
a7f9a88
@jbphet
Copy link
Contributor

jbphet commented Jul 22, 2020

This has been done, and there are no more usages of the inherit function in states-of-matter, states-of-matter-basics, and atomic-interactions. Closing.

@jbphet jbphet closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @jbphet