-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out/minimize overrides files. #303
Comments
I've committed several changes factoring out overrides from several places into the point of origination, I was able to do around one per minute (I focused on the ones that did not require simulation-specific knowledge), and it seemed a good use of time. For instance, atomic interactions is down from 27 to 19 overrides. I recommend taking a bit more time to look through and see if anything else is easy to factor out. |
@samreid - I have a few questions, and a comment, on this:
|
…e, see phetsims/states-of-matter#303" This reverts commit 020db61
…ode, see phetsims/states-of-matter#303" This reverts commit d44c27e
…ides to the code, see phetsims/states-of-matter#303" This reverts commit 8d4de35
This reverts commit b2cfefa. # Conflicts: # js/atomic-interactions/model/DualAtomModel.js
I reverted the changes and used |
I reviewed this by skimming through the overrides file history for SOM, SOMB, and AI, and they look pretty reasonable to me. The only thing in them is the |
Discovered during #299. The overrides files must be maintained along with the simulation, and things will be simpler if we can minimize them as much as possible.
This can be done safely by comparing
grunt generate-phet-io-api
before and after a change. I'll take a look.The text was updated successfully, but these errors were encountered: